Skip to content

fix timeline - #36

Open
Kistine wants to merge 1 commit into
gh-pagesfrom
trade-fix
Open

fix timeline#36
Kistine wants to merge 1 commit into
gh-pagesfrom
trade-fix

Conversation

@Kistine

@Kistine Kistine commented Aug 21, 2018

Copy link
Copy Markdown
Contributor

Simplified value statement and removed basefilter so chart would load

Simplified value statement and removed basefilter so chart would load
@Kistine

Kistine commented Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

@timwis - for when you're back, would like your review that it's ok to remove the basefilter. timeline chart wouldn't load with it included, but want to make sure it's not necessary before pushing live.

@Kistine Kistine self-assigned this Aug 21, 2018
@Kistine
Kistine requested a review from timwis August 21, 2018 18:33
@timwis

timwis commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

Is this working for you when you preview it on your computer? It looks like the to_date() function was in there previously, which suggests the field type in the database was a string rather than a date. The only way that wouldn't be necessary now, I imagine, is if the field type was changed (which would have required @Alexander-M-Waldman to change the schema file for the carto sync to work). But yes if it's working for you locally then I'd say good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants